beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-3081) Our findbugs config does not actually use Nullable annotations effectively
Date Wed, 25 Oct 2017 19:36:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219369#comment-16219369
] 

ASF GitHub Bot commented on BEAM-3081:
--------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/4039

    [BEAM-3081] Findbugs stragglers

    Follow this checklist to help us incorporate your contribution quickly and easily:
    
     - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/)
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
     - [x] Each commit in the pull request should have a meaningful subject line and body.
     - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [x] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
     - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
     - [x] If this contribution is large, please file an Apache [Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    I did not do a sufficient offline verification during our Jenkins issues. Confirmed that
findbugs fails on `master` and succeeds after this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam findbugs-stragglers

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/4039.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4039
    
----
commit 84a1df9139a0fa65be6e19db2a106bd082c8ae26
Author: Kenneth Knowles <kenn@apache.org>
Date:   2017-10-25T16:38:55Z

    Fix remaining nullability errors

----


> Our findbugs config does not actually use Nullable annotations effectively
> --------------------------------------------------------------------------
>
>                 Key: BEAM-3081
>                 URL: https://issues.apache.org/jira/browse/BEAM-3081
>             Project: Beam
>          Issue Type: Improvement
>          Components: build-system
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>
> We use {{@Nullable}} annotations mostly appropriately, but in fact our findbugs config
was not delivering value based on these annotations, because it does not default to {{@NonNull}}.
We can and should set this default.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message