beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-3061) BigtableIO should support emitting a sentinel "done" value when a bundle completes
Date Mon, 16 Oct 2017 15:05:00 GMT


ASF GitHub Bot commented on BEAM-3061:

GitHub user steveniemitz opened a pull request:

    [BEAM-3061] Done notification for BigtableIO.write()

    Follow this checklist to help us incorporate your contribution quickly and easily:
     - [x] Make sure there is a [JIRA issue](
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
     - [x] Each commit in the pull request should have a meaningful subject line and body.
     - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [x] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
     - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
     - [x] If this contribution is large, please file an Apache [Individual Contributor License
    This adds support for "done" notification in `BigtableIO.write()`.  For each bundle that
is completely written, a single "Void" is output by the PTransform.  Doing so allows flows
to effectively wait for all writes to finish.
    This works well for batch flows (and I've been using for a few weeks now in some large
ones), but there is some limitation on the streaming side.
    For streaming writes, all "done" notifications are output into the global window, rather
than the window(s?) that was(were) written in that bundle.  I'm not very familiar with the
interactions of bundles, windows, and panes in the streaming API, so I haven't tried to solve
this at all, although for this IO specifically it seems doable.

You can merge this pull request into a Git repository by running:

    $ git pull bigtable-done-notification

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3997
commit b6848d54c4eac2942abed6ce363aaa5ae3f2ba05
Author: steve <>
Date:   2017-09-25T14:21:40Z

    Done notification for BigtableIO


> BigtableIO should support emitting a sentinel "done" value when a bundle completes
> ----------------------------------------------------------------------------------
>                 Key: BEAM-3061
>                 URL:
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-gcp
>            Reporter: Steve Niemitz
>            Assignee: Steve Niemitz
> There was some discussion of this on the dev@ mailing list [1].  This approach was taken
based on discussion there.
> [1]

This message was sent by Atlassian JIRA

View raw message