beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-3052) ReduceFnRunner sets end-of-window hold even when no data is buffered
Date Thu, 12 Oct 2017 22:06:00 GMT


ASF GitHub Bot commented on BEAM-3052:

GitHub user kennknowles opened a pull request:

    [BEAM-3052] ReduceFnRunner: unconditionally set only GC hold and timer; AfterWatermarkStateMachine:
always set EOW timer

    Follow this checklist to help us incorporate your contribution quickly and easily:
     - [x] Make sure there is a [JIRA issue](
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
     - [x] Each commit in the pull request should have a meaningful subject line and body.
     - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [x] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
     - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
     - [x] If this contribution is large, please file an Apache [Individual Contributor License

You can merge this pull request into a Git repository by running:

    $ git pull on-time-gc

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3988
commit db17a188ab98379e2985d01e63eaa2c4bb5893fd
Author: Kenneth Knowles <>
Date:   2017-10-12T20:38:27Z

    Set end-of-window timer in AfterWatermarkStateMachine

commit 7a56ed88851688e270c868601dd24be8b2a4e12b
Author: Kenneth Knowles <>
Date:   2017-09-22T22:57:01Z

    Set garbage collection timer and watermark hold unconditionally


> ReduceFnRunner sets end-of-window hold even when no data is buffered
> --------------------------------------------------------------------
>                 Key: BEAM-3052
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
> If you set a trigger that ignores the end of the window (like repeated processing time
trigger) and an early firing emits all the data, the ReduceFnRunner will leave an end-of-window
watermark hold in place but only a GC timer.

This message was sent by Atlassian JIRA

View raw message