beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-3049) Java SDK Harness bundles non-relocated code, including Dataflow runner
Date Tue, 17 Oct 2017 02:57:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206940#comment-16206940
] 

ASF GitHub Bot commented on BEAM-3049:
--------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/4003

    [BEAM-3049] Relocate everything shaded by Java SDK harness

    Follow this checklist to help us incorporate your contribution quickly and easily:
    
     - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/)
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
     - [x] Each commit in the pull request should have a meaningful subject line and body.
     - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [x] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
     - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
     - [x] If this contribution is large, please file an Apache [Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    R: @herohde 
    
    Verified that everything in the shaded jar begins with `org.apache.beam.fn.harness` which
is the current namespace adopted by the SDK harness code.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam harness-shading

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/4003.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4003
    
----
commit 008909392b5b4e7227e07f4a11e13d799100fd46
Author: Kenneth Knowles <kenn@apache.org>
Date:   2017-10-17T02:51:50Z

    Relocate everything shaded by Java SDK harness

----


> Java SDK Harness bundles non-relocated code, including Dataflow runner
> ----------------------------------------------------------------------
>
>                 Key: BEAM-3049
>                 URL: https://issues.apache.org/jira/browse/BEAM-3049
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-harness
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>
> This causes a problem if something depends on the harness but does not want the harness's
copy of its dependencies. I know we intend to break the dependency on the Dataflow runner.
It also bundles a couple other things unshaded.
> Mostly, the harness should be executed entirely containerized so it doesn't matter, in
which case there's no need to relocate anything, and bundling is just a convenience. But we
should have a clear policy that we adhere to. Either it is a library and should have good
hygeine, or if it doesn't have good hygeine it must not be used as a library.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message