beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-3037) Java DirectRunner jar includes non-relocated runner api protos
Date Mon, 09 Oct 2017 20:09:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197622#comment-16197622
] 

ASF GitHub Bot commented on BEAM-3037:
--------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/3964

    [BEAM-3037] Relocate sdks.common.v1 and portability.v1 in Java direct runner

    Currently these two namespaces are mistakenly left as-is, even though they link
    to other relocated proto libraries that make them incompatible when used
    outside the direct runner.
    
    Follow this checklist to help us incorporate your contribution quickly and easily:
    
     - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/)
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
     - [x] Each commit in the pull request should have a meaningful subject line and body.
     - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [x] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
     - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
     - [x] If this contribution is large, please file an Apache [Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    R: @tgroh 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam DirectRunner-shading

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3964.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3964
    
----
commit 1b59e4d443a346e10a6bbb03492f6b83d207cf85
Author: Kenneth Knowles <klk@google.com>
Date:   2017-10-09T20:06:36Z

    Relocate sdks.common.v1 and portability.v1 in Java direct runner
    
    Currently these two namespaces are mistakenly left as-is, even though they link
    to other relocated proto libraries that make them incompatible when used
    outside the direct runner.

----


> Java DirectRunner jar includes non-relocated runner api protos
> --------------------------------------------------------------
>
>                 Key: BEAM-3037
>                 URL: https://issues.apache.org/jira/browse/BEAM-3037
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-direct
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>
> The DirectRunner jar includes classes like {{org.apache.beam.portability.v1.Endpoints}}
that actually extend a shaded proto library {{org.apache.beam.runner.direct.repackaged.portability.v1.Endpoints}}
so you get very inscrutable messages.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message