beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-3035) Extract ReifyTimestampsAndWindows from GatherAllPanes
Date Sun, 29 Oct 2017 07:37:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-3035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223882#comment-16223882
] 

ASF GitHub Bot commented on BEAM-3035:
--------------------------------------

GitHub user wtanaka opened a pull request:

    https://github.com/apache/beam/pull/4057

    [BEAM-3035] Extract ReifyTimestampsAndWindows

    from GatherAllPanes

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wtanaka/beam reify

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/4057.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4057
    
----
commit e9b5cf823813ea01ff161179619ec196d463cdf2
Author: wtanaka.com <wtanaka@users.noreply.github.com>
Date:   2017-10-07T18:45:45Z

    [BEAM-3035] Extract ReifyTimestampsAndWindows
    
    from GatherAllPanes

----


> Extract ReifyTimestampsAndWindows from GatherAllPanes
> -----------------------------------------------------
>
>                 Key: BEAM-3035
>                 URL: https://issues.apache.org/jira/browse/BEAM-3035
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-core
>    Affects Versions: 2.1.0
>            Reporter: Wesley Tanaka
>            Assignee: Kenneth Knowles
>            Priority: Minor
>
> The {{ReifyTimestampsAndWindowsFn}} in {{GatherAllPanes}} looks useful for giving {{MapElements}},
 {{Filter}}, etc access to window and pane information.
> This JIRA represents the proposal to extract a subset of the {{GatherAllPanes}} functionality
into a new class {{ReifyTimestampsAndWindows}}, next to {{ReifyTimestamps}} which does similar
functionality but with {{TimestampedValue}}
> {{GatherAllPanes}} would then rely on the newly extracted public {{PTransform}} for its
previous functionality.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message