beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-3019) make AvroIOWriteTransformTest more generic
Date Thu, 05 Oct 2017 09:48:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192673#comment-16192673
] 

ASF GitHub Bot commented on BEAM-3019:
--------------------------------------

GitHub user echauchot opened a pull request:

    https://github.com/apache/beam/pull/3948

    [BEAM-3019] Make AvroIOReadTransformTest more generic

    Follow this checklist to help us incorporate your contribution quickly and easily:
    
     - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/)
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
     - [X] Each commit in the pull request should have a meaningful subject line and body.
     - [X] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [X] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
     - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
     - [X] If this contribution is large, please file an Apache [Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    - Make runTestWrite() more generic to be able to use GenericRecord[] as input for writeGenericRecords
test in place of AvroGeneratedUser
    - Make readAvroFile() generic to be able to read GenericRecords using GenericDatumReader
for writeGenericRecords test
    R: @jkff 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/echauchot/beam AvroIO_improve_AvroIOWriteTransformTest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3948.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3948
    
----
commit 133d095c0df7f9c0b48aa7dde96512c09e3f1881
Author: Etienne Chauchot <echauchot@gmail.com>
Date:   2017-10-05T09:45:12Z

    [BEAM-3019] Make AvroIOReadTransformTest more generic
    
    make runTestWrite() more generic to be able to use GenericRecord[] as input for writeGenericRecords
test in place of AvroGeneratedUser
    make readAvroFile() generic to be able to read GenericRecords using GenericDatumReader
for writeGenericRecords test

----


> make AvroIOWriteTransformTest more generic
> ------------------------------------------
>
>                 Key: BEAM-3019
>                 URL: https://issues.apache.org/jira/browse/BEAM-3019
>             Project: Beam
>          Issue Type: Test
>          Components: sdk-java-extensions, testing
>            Reporter: Etienne Chauchot
>            Assignee: Etienne Chauchot
>
> make {{runTestWrite()}} more generic to be able to use {{GenericRecord[]}} as input for
{{writeGenericRecords}} test in place of {{AvroGeneratedUser}}
> make {{readAvroFile()}} generic to be able to read {{GenericRecords}} using {{GenericDatumReader}}
for {{writeGenericRecords}} test



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message