beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2779) PipelineOptionsFactory should prevent non PipelineOptions interfaces from being constructed.
Date Wed, 11 Oct 2017 23:12:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16201149#comment-16201149
] 

ASF GitHub Bot commented on BEAM-2779:
--------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/3949


> PipelineOptionsFactory should prevent non PipelineOptions interfaces from being constructed.
> --------------------------------------------------------------------------------------------
>
>                 Key: BEAM-2779
>                 URL: https://issues.apache.org/jira/browse/BEAM-2779
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>    Affects Versions: 2.0.0
>            Reporter: Luke Cwik
>            Assignee: Kai Jiang
>            Priority: Minor
>              Labels: starter
>             Fix For: 2.3.0
>
>
> PipelineOptions currently serializes information about all getter/setter pairs on interfaces
which don't extend PipelineOptions.
> For example:
> {code:java}
> interface Foo extends PipelineOptions, Bar {
>   String getFoo();
>   void setFoo(String value);
> }
> interface Bar {
>   String getBar();
>   void setBar(String value);
> }
> {code}
> The serialization of the above (when both *foo* and *bar* are set) will produce JSON
where we only include display data for *foo* but data for both *foo* and *bar*. During validation
of an interface in *PipelineOptionsFactory*, we should throw an error if one of the users
interfaces doesn't extend *PipelineOptions* (note that we should ignore the HasDisplayData
interface).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message