beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2566) Java SDK harness should not depend on any runner
Date Thu, 19 Oct 2017 19:05:01 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211556#comment-16211556
] 

ASF GitHub Bot commented on BEAM-2566:
--------------------------------------

GitHub user lukecwik opened a pull request:

    https://github.com/apache/beam/pull/4016

    [BEAM-2566] Decouple SDK harness from Dataflow runner by elevating experiments and SDK
harness configuration to java-sdk-core.

    Follow this checklist to help us incorporate your contribution quickly and easily:
    
     - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/)
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
     - [ ] Each commit in the pull request should have a meaningful subject line and body.
     - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [ ] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
     - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
     - [ ] If this contribution is large, please file an Apache [Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    I'm entertaining name changes on the options interfaces or any suggestions on how to make
it easier to migrate from DataflowWorkerLoggingOptions to SdkHarnessOptions for logging configuration.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukecwik/incubator-beam beam2566

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/4016.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4016
    
----
commit 8b524c64e203c26ddab05d8adb4f86711fecfadc
Author: Luke Cwik <lcwik@google.com>
Date:   2017-10-19T18:26:04Z

    [BEAM-2566] Decouple SDK harness from Dataflow runner by elevating experiments and SDK
harness configuration to java-sdk-core.

----


> Java SDK harness should not depend on any runner
> ------------------------------------------------
>
>                 Key: BEAM-2566
>                 URL: https://issues.apache.org/jira/browse/BEAM-2566
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Thomas Groh
>              Labels: portability
>
> Right now there is a dependency on the Dataflow runner. I believe this is legacy due
to using {{CloudObject}} temporarily but I do not claim to understand the full nature of the
dependency.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message