beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From k...@apache.org
Subject [3/4] beam git commit: Manage RAT plugin more centrally; only toggle skipping
Date Wed, 25 Oct 2017 03:07:20 GMT
Manage RAT plugin more centrally; only toggle skipping


Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/cd6379b0
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/cd6379b0
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/cd6379b0

Branch: refs/heads/master
Commit: cd6379b02d0f43659eac3941a3f63a1fed607de9
Parents: 6b572ff
Author: Kenneth Knowles <kenn@apache.org>
Authored: Mon Oct 23 13:26:27 2017 -0700
Committer: Kenneth Knowles <kenn@apache.org>
Committed: Tue Oct 24 19:54:54 2017 -0700

----------------------------------------------------------------------
 pom.xml | 30 +++++++++++++++++++-----------
 1 file changed, 19 insertions(+), 11 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/beam/blob/cd6379b0/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index eeba1ba..73453ff 100644
--- a/pom.xml
+++ b/pom.xml
@@ -157,6 +157,7 @@
     <kafka.clients.version>0.11.0.1</kafka.clients.version>
     <commons.csv.version>1.4</commons.csv.version>
 
+    <apache-rat-plugin.version>0.12</apache-rat-plugin.version>
     <os-maven-plugin.version>1.5.0.Final</os-maven-plugin.version>
     <groovy-maven-plugin.version>2.0</groovy-maven-plugin.version>
     <surefire-plugin.version>2.20</surefire-plugin.version>
@@ -184,6 +185,9 @@
 
     <!-- For container builds, override to push containers to any registry -->
     <docker-repository-root>${user.name}-docker-apache.bintray.io/beam</docker-repository-root>
+
+    <!-- Default skipping -->
+    <rat.skip>true</rat.skip>
   </properties>
 
   <packaging>pom</packaging>
@@ -247,15 +251,11 @@
             <plugin>
               <groupId>org.apache.rat</groupId>
               <artifactId>apache-rat-plugin</artifactId>
-              <executions>
-                <execution>
-                  <phase>verify</phase>
-                  <goals>
-                    <goal>check</goal>
-                  </goals>
-                </execution>
-              </executions>
+              <configuration>
+                <skip>false</skip>
+              </configuration>
             </plugin>
+
             <plugin>
               <groupId>org.apache.maven.plugins</groupId>
               <artifactId>maven-resources-plugin</artifactId>
@@ -268,8 +268,6 @@
           <plugin>
             <groupId>org.apache.rat</groupId>
             <artifactId>apache-rat-plugin</artifactId>
-            <!-- Apache RAT checks all files in the project, only run once. -->
-            <inherited>false</inherited>
           </plugin>
 
           <plugin>
@@ -1536,7 +1534,17 @@
         <plugin>
           <groupId>org.apache.rat</groupId>
           <artifactId>apache-rat-plugin</artifactId>
-          <version>0.12</version>
+          <version>${apache-rat-plugin.version}</version>
+          <!-- Apache RAT checks all files in the project, only run once. -->
+          <inherited>false</inherited>
+          <executions>
+            <execution>
+              <phase>verify</phase>
+              <goals>
+                <goal>check</goal>
+              </goals>
+            </execution>
+          </executions>
           <configuration>
             <reportFile>${project.build.directory}/${project.build.finalName}.rat</reportFile>
             <excludeSubProjects>false</excludeSubProjects>


Mime
View raw message