beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rober...@apache.org
Subject [13/18] beam git commit: Re-order comment (reviewer feedback)
Date Thu, 12 Oct 2017 22:54:49 GMT
Re-order comment (reviewer feedback)


Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/14cf6a13
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/14cf6a13
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/14cf6a13

Branch: refs/heads/master
Commit: 14cf6a13a3e3152ca8f168535500a95f16db07b2
Parents: bf910c1
Author: Holden Karau <holden@us.ibm.com>
Authored: Thu Sep 7 23:38:37 2017 -0700
Committer: Robert Bradshaw <robertwb@gmail.com>
Committed: Thu Oct 12 15:53:55 2017 -0700

----------------------------------------------------------------------
 .../examples/complete/juliaset/juliaset/juliaset.py            | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/beam/blob/14cf6a13/sdks/python/apache_beam/examples/complete/juliaset/juliaset/juliaset.py
----------------------------------------------------------------------
diff --git a/sdks/python/apache_beam/examples/complete/juliaset/juliaset/juliaset.py b/sdks/python/apache_beam/examples/complete/juliaset/juliaset/juliaset.py
index bb5b185..165237d 100644
--- a/sdks/python/apache_beam/examples/complete/juliaset/juliaset/juliaset.py
+++ b/sdks/python/apache_beam/examples/complete/juliaset/juliaset/juliaset.py
@@ -104,12 +104,12 @@ def run(argv=None):  # pylint: disable=missing-docstring
 
     coordinates = generate_julia_set_colors(p, complex(-.62772, .42193), n, 100)
 
-    # Group each coordinate triplet by its x value, then write the coordinates
-    # to the output file with an x-coordinate grouping per line.
-    # pylint: disable=expression-not-assigned
     def x_coord_key(x_y_i):
       return (x_y_i[0], (x_y_i[0], x_y_i[1], x_y_i[2]))
 
+    # Group each coordinate triplet by its x value, then write the coordinates
+    # to the output file with an x-coordinate grouping per line.
+    # pylint: disable=expression-not-assigned
     (coordinates
      | 'x coord key' >> beam.Map(x_coord_key)
      | 'x coord' >> beam.GroupByKey()


Mime
View raw message