Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0A8CD200D0A for ; Wed, 20 Sep 2017 01:14:12 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 08DC51609E0; Tue, 19 Sep 2017 23:14:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 443A81609DD for ; Wed, 20 Sep 2017 01:14:11 +0200 (CEST) Received: (qmail 30247 invoked by uid 500); 19 Sep 2017 23:14:10 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 30237 invoked by uid 99); 19 Sep 2017 23:14:10 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Sep 2017 23:14:10 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 5858AF56AC; Tue, 19 Sep 2017 23:14:10 +0000 (UTC) From: pedapudi To: commits@beam.apache.org Reply-To: commits@beam.apache.org Message-ID: Subject: [GitHub] beam pull request #3868: Add Nullable Metric getter to MetricsContainerImpl. Content-Type: text/plain Date: Tue, 19 Sep 2017 23:14:10 +0000 (UTC) archived-at: Tue, 19 Sep 2017 23:14:12 -0000 GitHub user pedapudi opened a pull request: https://github.com/apache/beam/pull/3868 Add Nullable Metric getter to MetricsContainerImpl. MetricsContainerImpl currently creates a Counter with a given name when attempting to read that Counter. In order to read potentially non-existent Counters, a getter that doesn't create a Counter on behalf of the reader is necessary. 'tryGetCounter' introduces a way to retrieve null Counter values. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pedapudi/beam nullable-metric-getter Alternatively you can review and apply these changes as the patch at: https://github.com/apache/beam/pull/3868.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3868 ---- commit ffeb889e46ac9bb9e4f55de880835a4e6b38d7df Author: Sunil Pedapudi Date: 2017-09-19T21:55:43Z MetricsContainerImpl: Add Nullable getter. ---- ---