beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chamikaramj <...@git.apache.org>
Subject [GitHub] beam pull request #3892: [BEAM-2985] Updates WriteToBigQuery PTransform to g...
Date Sat, 23 Sep 2017 01:15:16 GMT
GitHub user chamikaramj opened a pull request:

    https://github.com/apache/beam/pull/3892

    [BEAM-2985] Updates WriteToBigQuery PTransform to get project id from GoogleCloud…

    …Options when using DirectRunner.
    
    WriteToBigQuery PTransform behaves differently for DirectRunner and DataflowRunner when
it comes to determining the project that the output table belongs to. If a project is not
specified, DataflowRunner defauls to GoogleCloudOptions.project while DirectRunner does not.
This PR fixes this inconsistency by defaulting to GoogleCloudOptions.project for DirectRunner
as well.
    
    Follow this checklist to help us incorporate your contribution quickly and easily:
    
     - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/)
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
     - [ ] Each commit in the pull request should have a meaningful subject line and body.
     - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [ ] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
     - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
     - [ ] If this contribution is large, please file an Apache [Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chamikaramj/beam bq_direct_runner_write

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3892.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3892
    
----
commit f99db7932cab90dda2741d22b291e7f1eaad7336
Author: chamikara@google.com <chamikara@google.com>
Date:   2017-09-23T00:59:50Z

    Updates WriteToBigQuery PTransform to get project id from GoogleCloudOptions when using
DirectRunner.
    
    WriteToBigQuery PTransform behaves differently for DirectRunner and DataflowRunner when
it comes to determining the project that the output table belongs to. If a project is not
specified, DataflowRunner defauls to GoogleCloudOptions.project while DirectRunner does not.
This PR fixes this inconsistency by defaulting to GoogleCloudOptions.project for DirectRunner
as well.

----


---

Mime
View raw message