beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pedapudi <>
Subject [GitHub] beam pull request #3868: Add Nullable Metric getter to MetricsContainerImpl.
Date Tue, 19 Sep 2017 23:14:10 GMT
GitHub user pedapudi opened a pull request:

    Add Nullable Metric getter to MetricsContainerImpl.

    MetricsContainerImpl currently creates a Counter with a given name when attempting to
read that Counter. In order to read potentially non-existent Counters, a getter that doesn't
create a Counter on behalf of the reader is necessary. 'tryGetCounter' introduces a way to
retrieve null Counter values.

You can merge this pull request into a Git repository by running:

    $ git pull nullable-metric-getter

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3868
commit ffeb889e46ac9bb9e4f55de880835a4e6b38d7df
Author: Sunil Pedapudi <>
Date:   2017-09-19T21:55:43Z

    MetricsContainerImpl: Add Nullable getter.



View raw message