beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From echauchot <...@git.apache.org>
Subject [GitHub] beam pull request #3850: [BEAM-2790] Use byte[] instead of ByteBuffer to rea...
Date Thu, 14 Sep 2017 09:27:47 GMT
GitHub user echauchot opened a pull request:

    https://github.com/apache/beam/pull/3850

    [BEAM-2790] Use byte[] instead of ByteBuffer to read from HadoopFilesystem

    Follow this checklist to help us incorporate your contribution quickly and easily:
    
     - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/)
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
     - [X] Each commit in the pull request should have a meaningful subject line and body.
     - [X] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [X] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
     - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
     - [X] If this contribution is large, please file an Apache [Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    This is the continuation of PR https://github.com/apache/beam/pull/3744. It fixes the
code to deal with the offsets/limits to have the same behavior than read(ByteBuffer) and it
adds corner cases tests.
    R: @lukecwik @steveloughran
    CC: @iemejia 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/echauchot/beam byte_array_instead_of_ByBuffer_HadoopFS2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3850.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3850
    
----
commit ed5ba0c2ecc6e3a0b305cb9928d610f8ab58acbe
Author: Etienne Chauchot <echauchot@gmail.com>
Date:   2017-09-14T08:28:12Z

    [BEAM-2790] Use byte[] instead of ByteBuffer to read from HadoopFilesystem

----


---

Mime
View raw message