beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2999) Split validatesrunner tests from Python postcommit
Date Sat, 30 Sep 2017 20:12:02 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187198#comment-16187198
] 

ASF GitHub Bot commented on BEAM-2999:
--------------------------------------

GitHub user markflyhigh opened a pull request:

    https://github.com/apache/beam/pull/3927

    [BEAM-2999] Move ValidatesRunner test out of Python postcommit

    Follow this checklist to help us incorporate your contribution quickly and easily:
    
     - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/)
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
     - [ ] Each commit in the pull request should have a meaningful subject line and body.
     - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [ ] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
     - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
     - [ ] If this contribution is large, please file an Apache [Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    Create separate Jenkins build for Python validatesrunner tests and move them out of `beam_PostCommit_Python_Verify`.

    
    `beam_PostCommit_Python_Verify` is pretty heavy combining with unit tests, validatesrunner
tests and end-to-end tests, and the total time increase to 1 hour recently. This change can
reduce the load of `beam_PostCommit_Python_Verify` and log will be cleaner for debugging if
either build failed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markflyhigh/incubator-beam python-split-postcommit

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3927.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3927
    
----
commit 47f4d32299211768211d2eef72e17a00393ff4f0
Author: Mark Liu <markliu@google.com>
Date:   2017-09-28T01:18:02Z

    [BEAM-2999] Split ValidatesRunner test from Python Postcommit

commit 612ce7e9b0e7c64d33887d58f108ff32b0056de9
Author: Mark Liu <markliu@google.com>
Date:   2017-09-30T19:58:07Z

    fixup! Clean up tox related setup

----


> Split validatesrunner tests from Python postcommit
> --------------------------------------------------
>
>                 Key: BEAM-2999
>                 URL: https://issues.apache.org/jira/browse/BEAM-2999
>             Project: Beam
>          Issue Type: Bug
>          Components: testing
>            Reporter: Mark Liu
>            Assignee: Mark Liu
>
> The only Python Postcommit Jenkins build includes too many tests which makes the build
(and test) time over 1 hour. Also it became hard to found error in long console logs if build
failed.
> We can separate validatesrunner tests which currently take ~20mins out from the Postcommit
build to a separate Jenkins branch. This will shorten the total build time of Postcommit.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message