beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2997) Encapsulate all proto enum types within a message so that they are namespaced in C++/Python
Date Fri, 29 Sep 2017 17:16:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16186104#comment-16186104
] 

ASF GitHub Bot commented on BEAM-2997:
--------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/3913


> Encapsulate all proto enum types within a message so that they are namespaced in C++/Python
> -------------------------------------------------------------------------------------------
>
>                 Key: BEAM-2997
>                 URL: https://issues.apache.org/jira/browse/BEAM-2997
>             Project: Beam
>          Issue Type: Improvement
>          Components: beam-model, sdk-java-core, sdk-py-core
>            Reporter: Luke Cwik
>            Assignee: Luke Cwik
>
> Python/C++ dump enums into the parent namespace. By placing the enum within a containing
message, we can provide a meaningful name for enums and avoid collisions in names.
> See:
> https://developers.google.com/protocol-buffers/docs/cpptutorial#enums-and-nested-classes
> https://developers.google.com/protocol-buffers/docs/pythontutorial#enums



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message