beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2996) Metric names should not be null or empty
Date Wed, 27 Sep 2017 21:46:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183305#comment-16183305
] 

ASF GitHub Bot commented on BEAM-2996:
--------------------------------------

GitHub user bjchambers opened a pull request:

    https://github.com/apache/beam/pull/3914

    [BEAM-2996] Ensure metric names are not null or empty

    Follow this checklist to help us incorporate your contribution quickly and easily:
    
     - [*] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/)
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
     - [*] Each commit in the pull request should have a meaningful subject line and body.
     - [*] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [*] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
     - [*] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
     - [*] If this contribution is large, please file an Apache [Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bjchambers/beam metric-names

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3914.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3914
    
----
commit 8635e46ca2be718e9a5a32108be177b2a096ca51
Author: bchambers <bchambers@google.com>
Date:   2017-09-27T17:44:48Z

    Ensure metric names are not null or empty

----


> Metric names should not be null or empty
> ----------------------------------------
>
>                 Key: BEAM-2996
>                 URL: https://issues.apache.org/jira/browse/BEAM-2996
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core, sdk-py-core
>            Reporter: Ben Chambers
>            Assignee: Ben Chambers
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message