beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luke Cwik (JIRA)" <>
Subject [jira] [Commented] (BEAM-2959) Fix proto enums to not use 0 for a valid value
Date Fri, 15 Sep 2017 19:44:00 GMT


Luke Cwik commented on BEAM-2959:

Note that making this change I discovered a bug in how windowing strategy translation was
being performed which will cause an error.

> Fix proto enums to not use 0 for a valid value
> ----------------------------------------------
>                 Key: BEAM-2959
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: beam-model
>            Reporter: Luke Cwik
>            Assignee: Luke Cwik
>            Priority: Minor
>             Fix For: 2.2.0
> Proto3 uses 0 as the default value for enums and does not encode it on the wire which
means that you can not detect the difference between a value that is unset and an enum that
is set but has a value of zero.
> Defining an "YYY_UNSPECIFIED" is considered a best practice. Unfortunately this is not
done automatically because of proto2 compatibility within proto3.

This message was sent by Atlassian JIRA

View raw message