beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-2866) StateTable should key off state id, not StateTag, since coders may have bad equality
Date Fri, 08 Sep 2017 02:50:02 GMT


ASF GitHub Bot commented on BEAM-2866:

GitHub user kennknowles opened a pull request:

    [BEAM-2866] Key StateTable off ID

    Follow this checklist to help us incorporate your contribution quickly and easily:
     - [ ] Make sure there is a [JIRA issue](
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
     - [ ] Each commit in the pull request should have a meaningful subject line and body.
     - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [ ] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
     - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
     - [ ] If this contribution is large, please file an Apache [Individual Contributor License

You can merge this pull request into a Git repository by running:

    $ git pull StateTag-key

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3818
commit 2d6799ad9b9fcdd924269656ea845d23f1169f65
Author: Kenneth Knowles <>
Date:   2017-09-08T02:36:17Z

    Add StateInternalsTest for bad coder equality

commit badf6205fc3334329bcc7cb640f1548850c339b5
Author: Kenneth Knowles <>
Date:   2017-09-08T02:48:18Z

    Key StateTable off id, not full StateTag


> StateTable should key off state id, not StateTag, since coders may have bad equality
> ------------------------------------------------------------------------------------
>                 Key: BEAM-2866
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>             Fix For: 2.2.0

This message was sent by Atlassian JIRA

View raw message