beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2836) Apply futurize stage 1 ("safe")
Date Sat, 02 Sep 2017 05:00:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151410#comment-16151410
] 

ASF GitHub Bot commented on BEAM-2836:
--------------------------------------

GitHub user holdenk opened a pull request:

    https://github.com/apache/beam/pull/3804

    [BEAM-2836] Run the "safe" futurize stage, and then fix the parts which parts which weren't
"safe"

    Run the safe futurize stage, this only broke a few tests (yay), it did introduce a number
of long-line issues with lambdas mostly fixed and refactoring them into regular functions.
    
    The two main things that had to be fixed after stage 1 futurize is expected error message
in type inference tests and type inference on iterable/tuple access.
    
    To keep people from inadvertently breaking things until we have Python 3 support as part
of Jenkins this also updates run_pylint to verify that there are no changes suggested by futurize
stage 1.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/holdenk/beam BEAM-2836-futurize-stage-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3804.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3804
    
----
commit a5fe79e977d69dbcbd3ca9ba12f94dffb189bb0a
Author: Holden Karau <holden@us.ibm.com>
Date:   2017-09-02T02:43:06Z

    Futurize stage 1 run

commit b924740ceca1bac08652442e0a60a46d36a6d4a8
Author: Holden Karau <holden@us.ibm.com>
Date:   2017-09-02T02:53:42Z

    Add futurize to pylint script

commit 43bb552a54747064b148f7a4e0d6ac9946b813b1
Author: Holden Karau <holden@us.ibm.com>
Date:   2017-09-02T02:56:11Z

    re-order imports

commit a196f1568bd6fdea18f9d49480765fd4f81b47ad
Author: Holden Karau <holden@us.ibm.com>
Date:   2017-09-02T02:57:19Z

    Cleanup whitespace (autopep8 fix

commit 2804f8158c7bbf4c71c1dbb1431b322f5e8334fb
Author: Holden Karau <holden@us.ibm.com>
Date:   2017-09-02T03:49:40Z

    Change the ptransform_test to use assertEqual rather than assertTrue for improved debugging,
fix the error message we're looking for since we now throw a tuple exception instead

commit 6bff4d847129a20ebe4543c223922931cb0c02cc
Author: Holden Karau <holden@us.ibm.com>
Date:   2017-09-02T03:51:18Z

    Add special work to handle indexable return types. Introduce a base IndexableTypeConstraint.

commit 190710f6dbe7f9acba1e4318f0b1c8c6801f9906
Author: Holden Karau <holden@us.ibm.com>
Date:   2017-09-02T03:51:40Z

    Break down futurize pylint

commit 7c7c315fc2bdb27669ad4e15e15a345496fc4455
Author: Holden Karau <holden@us.ibm.com>
Date:   2017-09-02T04:38:47Z

    Fix remaining style issues from auto conversion, switch ref in pylint to stage 1 (stages
in futurize are apparently 1 indexed)

commit 85a27f9db6441fcc0dd552a1731bc84019fe2fd8
Author: Holden Karau <holden@us.ibm.com>
Date:   2017-09-02T04:43:35Z

    Restore license position that got screwed up

commit 2ffee69fd31a1f08c90a7224c0297a4c3c73aec6
Author: Holden Karau <holden@us.ibm.com>
Date:   2017-09-02T04:53:51Z

    Fix the pylint script checking futurize

----


> Apply futurize stage 1 ("safe")
> -------------------------------
>
>                 Key: BEAM-2836
>                 URL: https://issues.apache.org/jira/browse/BEAM-2836
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py
>            Reporter: holdenk
>            Assignee: Ahmet Altay
>
> Futurize has two stages: stage 1 & stage 2. In theory futurize stage 1 should be
safe, try and apply stage 1 on its own.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message