beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2808) Improve error message when DoFn @ProcessElement has the wrong window type
Date Fri, 15 Sep 2017 19:32:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168404#comment-16168404
] 

ASF GitHub Bot commented on BEAM-2808:
--------------------------------------

GitHub user youngoli opened a pull request:

    https://github.com/apache/beam/pull/3857

    [BEAM-2808] Improve error message when DoFn @ProcessElement has the wrong window type

    Modifying the error message from this:
    
    <Method> expects window type <Type>, which is not a supertype of actual window
type <Other Type>
    
    to this:
    
    <Method> unable to provide window -- expected window type from parameter (<Type>)
is not a supertype of actual window type assigned by windowing (<Other Type>)
    
    @lukecwik, can you review?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/youngoli/beam bugfix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3857.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3857
    
----
commit dea7271b64724ee0cace792a37ba5adc12fec588
Author: Daniel Oliveira <daniel.o.programmer@gmail.com>
Date:   2017-09-15T19:10:05Z

    [BEAM-2808] Improving error message in ParDo.validateWindowTypeForMethod.

----


> Improve error message when DoFn @ProcessElement has the wrong window type
> -------------------------------------------------------------------------
>
>                 Key: BEAM-2808
>                 URL: https://issues.apache.org/jira/browse/BEAM-2808
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Daniel Oliveira
>            Priority: Minor
>              Labels: starter
>
> The message today is something like this:
> {code}
> processElement(org.apache.beam.sdk.transforms.DoFn$ProcessContext,org.apache.beam.sdk.transforms.windowing.IntervalWindow)
expects window type org.apache.beam.sdk.transforms.windowing.IntervalWindow, which is not
a supertype of actual window type org.apache.beam.sdk.transforms.windowing.GlobalWindow
> {code}
> Someone suggested this:
> {code}
> processElement(org.apache.beam.sdk.transforms.DoFn$ProcessContext,org.apache.beam.sdk.transforms.windowing.IntervalWindow)
unable to provide window --  expects window type org.apache.beam.sdk.transforms.windowing.IntervalWindow
(from parameter), which is not a supertype of actual window type org.apache.beam.sdk.transforms.windowing.GlobalWindow
(assigned by windowing)
> {code}
> If anyone wants to pick this up and wordsmith it more, strip some of the namespaces (where
reasonable), etc, that would be great.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message