Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4758E2004F1 for ; Wed, 30 Aug 2017 15:00:12 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 45E8B168F78; Wed, 30 Aug 2017 13:00:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6F3AD168F79 for ; Wed, 30 Aug 2017 15:00:11 +0200 (CEST) Received: (qmail 54591 invoked by uid 500); 30 Aug 2017 13:00:10 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 54569 invoked by uid 99); 30 Aug 2017 13:00:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Aug 2017 13:00:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 5E8E918290F for ; Wed, 30 Aug 2017 13:00:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 25KMlRiUKtWG for ; Wed, 30 Aug 2017 13:00:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 2A0BE60EEB for ; Wed, 30 Aug 2017 13:00:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 36AB0E08C6 for ; Wed, 30 Aug 2017 13:00:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id DDE6324137 for ; Wed, 30 Aug 2017 13:00:02 +0000 (UTC) Date: Wed, 30 Aug 2017 13:00:02 +0000 (UTC) From: "Stas Levin (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (BEAM-2825) Improve readability of SparkGroupAlsoByWindowViaWindowSet MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 30 Aug 2017 13:00:12 -0000 [ https://issues.apache.org/jira/browse/BEAM-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147183#comment-16147183 ] Stas Levin edited comment on BEAM-2825 at 8/30/17 12:59 PM: ------------------------------------------------------------ [BEAM-2669] could possibly introduce minor changes to the {{SparkGroupAlsoByWindowViaWindowSet}} class, so it's best if the PR for [BEAM-2825] (i.e., this issue) is rebased off the one for [BEAM-2669]. was (Author: staslev): [BEAM-2669] could possibly introduce minor changes to the {{SparkGroupAlsoByWindowViaWindowSet}} class, so it's best if the PR for [BEAM-2825] is rebased off the one for [BEAM-2669]. > Improve readability of SparkGroupAlsoByWindowViaWindowSet > --------------------------------------------------------- > > Key: BEAM-2825 > URL: https://issues.apache.org/jira/browse/BEAM-2825 > Project: Beam > Issue Type: Task > Components: runner-spark > Reporter: Stas Levin > Assignee: Stas Levin > Priority: Minor > > It would be nice to address some of the readability issues one can currently observe in {{SparkGroupAlsoByWindowViaWindowSet}}, in particular: > # Long methods > # Long anonymous classes -- This message was sent by Atlassian JIRA (v6.4.14#64029)