beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From holdenk <...@git.apache.org>
Subject [GitHub] beam pull request #3785: [WIP][BREAM-2821] Run isort and autopep8 in prepara...
Date Tue, 29 Aug 2017 22:21:19 GMT
GitHub user holdenk opened a pull request:

    https://github.com/apache/beam/pull/3785

    [WIP][BREAM-2821] Run isort and autopep8 in preparation for futurize.

    In preparation for running futurize (py2/3 support) run isort on the imports and autopep8
( W391,W293,W291,E306,E305,E304,E303). This also adds isort to run_pylint but skips the files
where isort was doing things which conflicted with pylint.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/holdenk/beam BEAM-2821-isort-and-autopep8

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3785.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3785
    
----
commit bcfd638d0886dde3b3498772cb2f97719a2f1777
Author: Holden Karau <holden@us.ibm.com>
Date:   2017-08-29T19:56:34Z

    Isort the libraries

commit 4f95de768817880c6164d5b1f198c93b67fe40d6
Author: Holden Karau <holden@us.ibm.com>
Date:   2017-08-29T20:16:45Z

    autopep8 whitespace fixes W391,W293,W291,E306,E305,E304,E303

commit e7cbb5cd44d575396f486ad06183f8f12fe4dd92
Author: Holden Karau <holden@us.ibm.com>
Date:   2017-08-29T20:38:59Z

    Manual clean up of some isort issues

commit 3a5066afbc14dbfbcb470a439d3f61288f13c1f2
Author: Holden Karau <holden@us.ibm.com>
Date:   2017-08-29T20:45:22Z

    re-runisort -p apache_beam -w 79 -y -c

commit 7ecc5ffa4ea111140e3154ce28f286de7c6caa64
Author: Holden Karau <holden@us.ibm.com>
Date:   2017-08-29T21:02:17Z

    Re-do-cleanup & Manual fixes and skip the files that isort does annoying things to

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message