beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aaltay <...@git.apache.org>
Subject [GitHub] beam pull request #3775: Use the same termination logic in different places ...
Date Mon, 28 Aug 2017 20:35:22 GMT
GitHub user aaltay opened a pull request:

    https://github.com/apache/beam/pull/3775

    Use the same termination logic in different places in DataflowRunner

    Use the same termination check for `wait_until_finish` and `_is_in_terminal_state`. Note
that this only affects an `assert` with a TODO to improve it.
    
    The change is required for having clean fail messages instead of this assert for cases
similar to: https://builds.apache.org/view/A-D/view/Beam/job/beam_PostCommit_Python_Verify/3013/consoleFull
    (https://pantheon.corp.google.com/dataflow/job/2017-08-28_11_08_56-17324181904913254210?project=apache-beam-testing)
    
    R: @charlesccychen 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aaltay/beam cancel

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3775.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3775
    
----
commit 4460261f5ea7e5bf6bec682b8c0977d3623193b5
Author: Ahmet Altay <altay@google.com>
Date:   2017-08-28T20:32:32Z

    Use the same termination logic in different places

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message