beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kobisalant <...@git.apache.org>
Subject [GitHub] beam pull request #3749: remove kryo Serializer hard coded settings and add ...
Date Wed, 23 Aug 2017 12:27:11 GMT
GitHub user kobisalant opened a pull request:

    https://github.com/apache/beam/pull/3749

    remove kryo Serializer hard coded settings and add Serializable to se…

    Remove kryo Serializer hard coded settings and add Serializable to several classes.
    
    Had to add Serializable to PaneInfo and WindowedValue as they are being used in Spark
runner state which is cached and removing Kryo hard coded Serializer now means we use java
Serilizer by default.
    
    Follow this checklist to help us incorporate your contribution quickly and easily:
    
     - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/)
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
     - [ ] Each commit in the pull request should have a meaningful subject line and body.
     - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [ ] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
     - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
     - [ ] If this contribution is large, please file an Apache [Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kobisalant/incubator-beam BEAM-2669-Kryo-serialization-exception-when-dstream-is-cached

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3749.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3749
    
----
commit 8ae90166a4cee2546a79661f61a1b8fc8459d569
Author: ksalant <kobi.salant@gmail.com>
Date:   2017-08-23T11:54:46Z

    remove kryo Serializer hard coded settings and add Serializable to several classes

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message