beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chamikaramj <...@git.apache.org>
Subject [GitHub] beam pull request #3715: [BEAM-2711] Updates ByteKeyRangeTracker so that get...
Date Fri, 11 Aug 2017 00:40:35 GMT
GitHub user chamikaramj opened a pull request:

    https://github.com/apache/beam/pull/3715

    [BEAM-2711] Updates ByteKeyRangeTracker so that getFractionConsumed() does not fail for
completed trackers

    After this update:
    * getFractionConsumed() returns 1.0 after markDone() is set.
    * getFractionConsumed() returns 1.0 after tryReturnRecordAt() is invoked for a position
that is larger than or equal to the end key.
    
    This is similar to how getFractionConsumed() method of OffsetRangeTracker is implemented.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chamikaramj/beam key_range_progress

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3715.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3715
    
----
commit ba08ec3bfb1eead06772945ab888d910ffe7d436
Author: chamikara@google.com <chamikara@google.com>
Date:   2017-08-11T00:35:37Z

    Updates ByteKeyRangeTracker so that getFractionConsumed() does not fail for completed
trackers.
    
    After this update:
    * getFractionConsumed() returns 1.0 after markDone() is set.
    * getFractionConsumed() returns 1.0 after tryReturnRecordAt() is invoked for a position
that is larger than or equal to the end key.
    
    This is similar to how getFractionConsumed() method of OffsetRangeTracker is implemented.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message