beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xumingming <...@git.apache.org>
Subject [GitHub] beam pull request #3708: [BEAM-2740] introduce the new InnerBeamSqlEnv/BeamS...
Date Wed, 09 Aug 2017 11:02:26 GMT
GitHub user xumingming opened a pull request:

    https://github.com/apache/beam/pull/3708

    [BEAM-2740] introduce the new InnerBeamSqlEnv/BeamSqlEnv

    Summary:
    
    * Simplified `BeamSqlEnv`: now you can only register UDF/UDAF in `BeamSqlEnv`, and `BeamSqlEnv`
just record the udfName -> udfClass mapping, actually work will be done by `InnerBeamSqlEnv`.
        * `BeamSqlEnv` is only used by the surface API classes.
    * `InnerBeamSqlEnv` is actually the old `BeamSqlEnv`, it holds schema and planner.
      * `InnerBeamSqlEnv` is only used by the implementation classes.
    * `BeamSqlEnv` is converted to `InnerBeamSqlEnv` automatically in `BeamSql` and `BeamSqlCli`.
    * `BeamSqlEnv` and `InnerBeamSqlEnv` are quite different, so can not share the same interface.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xumingming/beam BEAM-2740

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3708.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3708
    
----
commit 80491a26456e1a4a1ffc0e4e00290de63b9617e4
Author: James Xu <xumingmingv@gmail.com>
Date:   2017-08-09T10:54:54Z

    [BEAM-2740] introduce InnerBeamSqlEnv to extract implementation related logic from BeamSqlEnv

commit 5074f830347e07ef0ba8396bc9a464a37eb089ec
Author: James Xu <xumingmingv@gmail.com>
Date:   2017-08-09T11:04:46Z

    add licence declaration for BeamRelTest

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message