beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From XuMingmin <...@git.apache.org>
Subject [GitHub] beam pull request #3675: [BEAM-2676] move BeamSqlRow and BeamSqlRowType to s...
Date Wed, 02 Aug 2017 08:23:45 GMT
GitHub user XuMingmin opened a pull request:

    https://github.com/apache/beam/pull/3675

    [BEAM-2676] move BeamSqlRow and BeamSqlRowType to sdk/java/core

    create a new PR to get rid of the huge rebase work after #3666.
    
    Following the discussion in [BEAM-2676](https://issues.apache.org/jira/browse/BEAM-2676),
the changes are outlined as:
    1. `BeamRecord` and `BeamRecordTypeProvider` are marked as `@Experimental`;
    2. `BeamRecord` is moved to sdk/core, which includes a default `BeamRecordTypeProvider`
to define type information; Also a `BeamRecordCoder` is provided as Coder;
    3. In _extension/sql_, `BeamSqlRecord` extends `BeamRecord`, `BeamSqlRecordTypeProvider`
extends `BeamRecordTypeProvider` to support SQL types; a new Coder `BeamSqlRecordCoder` is
provided to align better;

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/XuMingmin/beam BEAM-2676_2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3675.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3675
    
----
commit 09a7148e603f8d8521f916008f92b0e95ae7c14f
Author: mingmxu <mingmxu@ebay.com>
Date:   2017-08-02T08:20:50Z

    move BeamRecord to sdk/core

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message