beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-2825) Improve readability of SparkGroupAlsoByWindowViaWindowSet
Date Wed, 30 Aug 2017 13:06:00 GMT


ASF GitHub Bot commented on BEAM-2825:

GitHub user staslev opened a pull request:

    [BEAM-2825] Refactored SparkGroupAlsoByWindowViaWindowSet to improve …

    Follow this checklist to help us incorporate your contribution quickly and easily:
     - [ ] Make sure there is a [JIRA issue](
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
     - [ ] Each commit in the pull request should have a meaningful subject line and body.
     - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [ ] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
     - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
     - [ ] If this contribution is large, please file an Apache [Individual Contributor License

You can merge this pull request into a Git repository by running:

    $ git pull BEAM-2825-Improve-readability-of-SparkGroupAlsoByWindowViaWindowSet

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3793
commit 04068c95b158f04843517309ffe5d2543b206637
Author: Stas Levin <>
Date:   2017-08-30T09:01:32Z

    [BEAM-2825] Refactored SparkGroupAlsoByWindowViaWindowSet to improve readability.


> Improve readability of SparkGroupAlsoByWindowViaWindowSet
> ---------------------------------------------------------
>                 Key: BEAM-2825
>                 URL:
>             Project: Beam
>          Issue Type: Task
>          Components: runner-spark
>            Reporter: Stas Levin
>            Assignee: Stas Levin
>            Priority: Minor
> It would be nice to address some of the readability issues one can currently observe
in {{SparkGroupAlsoByWindowViaWindowSet}}, in particular:
> # Long methods
> # Long anonymous classes

This message was sent by Atlassian JIRA

View raw message