beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stas Levin (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (BEAM-2825) Improve readability of SparkGroupAlsoByWindowViaWindowSet
Date Wed, 30 Aug 2017 13:00:02 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147183#comment-16147183
] 

Stas Levin edited comment on BEAM-2825 at 8/30/17 12:59 PM:
------------------------------------------------------------

[BEAM-2669] could possibly introduce minor changes to the {{SparkGroupAlsoByWindowViaWindowSet}}
class, so it's best if the PR for [BEAM-2825] (i.e., this issue) is rebased off the one for
[BEAM-2669].


was (Author: staslev):
[BEAM-2669] could possibly introduce minor changes to the {{SparkGroupAlsoByWindowViaWindowSet}}
class, so it's best if the PR for [BEAM-2825] is rebased off the one for [BEAM-2669].

> Improve readability of SparkGroupAlsoByWindowViaWindowSet
> ---------------------------------------------------------
>
>                 Key: BEAM-2825
>                 URL: https://issues.apache.org/jira/browse/BEAM-2825
>             Project: Beam
>          Issue Type: Task
>          Components: runner-spark
>            Reporter: Stas Levin
>            Assignee: Stas Levin
>            Priority: Minor
>
> It would be nice to address some of the readability issues one can currently observe
in {{SparkGroupAlsoByWindowViaWindowSet}}, in particular:
> # Long methods
> # Long anonymous classes



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message