beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-2796) _ExecutorServiceParallelExecutor.await_for_completion does not actually await for _ExecutorService to shutdown
Date Wed, 23 Aug 2017 17:20:00 GMT


ASF GitHub Bot commented on BEAM-2796:

GitHub user rryk opened a pull request:

    [BEAM-2796] Actually wait for exector service to shutdown

    Currently executor service is leaking threads, which eventually complete, but may complicate
writing integration tests in frameworks that check for leaked threads. There is await_for_completion
in the _ExecutorService class, but it's not invoked from the _ExecutorServiceParallelExecutor.await_for_completion,
which is fixed in this pull request.

You can merge this pull request into a Git repository by running:

    $ git pull master

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3751
commit 2033d169ed70fd9292106fa8c476d1cc64804877
Author: Sergiy Byelozyorov <>
Date:   2017-08-23T17:04:31Z

    Actually wait for exector service to shutdown


> _ExecutorServiceParallelExecutor.await_for_completion does not actually await for _ExecutorService
to shutdown
> --------------------------------------------------------------------------------------------------------------
>                 Key: BEAM-2796
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-direct
>    Affects Versions: 2.2.0
>            Reporter: Sergiy Byelozyorov
>            Assignee: Thomas Groh
> It's missing a call to self.executor_service.await_completion()

This message was sent by Atlassian JIRA

View raw message