beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2791) DirectRunner shuts down when there are pending event time timers
Date Tue, 22 Aug 2017 18:39:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137174#comment-16137174
] 

ASF GitHub Bot commented on BEAM-2791:
--------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/3745

    [BEAM-2791] Add a test for an event time timer loop in ParDo

    Follow this checklist to help us incorporate your contribution quickly and easily:
    
     - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/)
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
     - [x] Each commit in the pull request should have a meaningful subject line and body.
     - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [x] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
     - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
     - [x] If this contribution is large, please file an Apache [Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    R: @tgroh adding this test to indicate the issue and link with JIRA, and will try to find
time to fix it later.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam timer-loop

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3745.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3745
    
----
commit 2a4d086c9e41b1bfcc495a166dac43e68bb82dbe
Author: Kenneth Knowles <klk@google.com>
Date:   2017-08-22T18:34:59Z

    Add a test for an event time timer loop in ParDo

----


> DirectRunner shuts down when there are pending event time timers
> ----------------------------------------------------------------
>
>                 Key: BEAM-2791
>                 URL: https://issues.apache.org/jira/browse/BEAM-2791
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-direct
>            Reporter: Kenneth Knowles
>            Assignee: Thomas Groh
>
> When there are pending event time timers for a window by definition they are within the
window so it should not be possible to GC the window nor to shut down the pipeline.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message