beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2703) KafkaIO: watermark outside the bounds of BoundedWindow
Date Thu, 24 Aug 2017 21:38:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140750#comment-16140750
] 

ASF GitHub Bot commented on BEAM-2703:
--------------------------------------

GitHub user rangadi opened a pull request:

    https://github.com/apache/beam/pull/3758

    [BEAM-2703] Fix min_timestamp used for KafkaIO watermark.

    Use correct -ve infinity timestamp in KafkaIO as suggested in description of [BEAM-2703].(https://issues.apache.org/jira/browse/BEAM-2703).

    
    +R: @davorbonaci.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rangadi/beam fix_min_timestamp

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3758.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3758
    
----
commit 8ed07054f78aa25f64e303ec5f13ffa6ae7e701c
Author: Raghu Angadi <rangadi@google.com>
Date:   2017-08-24T21:33:28Z

    Fix min_timestamp used for KafkaIO watermark.

----


> KafkaIO: watermark outside the bounds of BoundedWindow
> ------------------------------------------------------
>
>                 Key: BEAM-2703
>                 URL: https://issues.apache.org/jira/browse/BEAM-2703
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-extensions
>            Reporter: Chris Pettitt
>            Assignee: Raghu Angadi
>
> KafkaIO appears to use an incorrect lower bound for it's initial watermark with respect
to BoundedWindow.TIMESTAMP_MIN_VALUE.
> KafkaIO's initial watermark:
> new Instant(Long.MIN_VALUE) -> -9223372036854775808
> BoundedWindow.TIMESTAMP_MIN_VALUE:
> new Instant(TimeUnit.MICROSECONDS.toMillis(Long.MIN_VALUE)) -> -9223372036854775
> The difference is that the last three digits have been truncated due to the micro to
millis conversion.
> This difference can cause errors in runners that assert that the input watermark can
never regress as KafkaIO gives a value below the lower bound when no messages have been received
yet. For consistency it would probably be best for it to use BoundedWindow.TIMESTAMP_MIN_VALUE.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message