beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-2632) TextIOReadTest create pipelines with non-unique application names
Date Wed, 30 Aug 2017 06:51:00 GMT


ASF GitHub Bot commented on BEAM-2632:

GitHub user huafengw opened a pull request:

    [BEAM-2632] Use Junit Paramaterized test suits in TextIOReadTest

    Follow this checklist to help us incorporate your contribution quickly and easily:
     - [ ] Make sure there is a [JIRA issue](
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
     - [ ] Each commit in the pull request should have a meaningful subject line and body.
     - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [ ] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
     - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
     - [ ] If this contribution is large, please file an Apache [Individual Contributor License

You can merge this pull request into a Git repository by running:

    $ git pull fixtest

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3790
commit cf75821f3175135e60999ba748377b0202f7cfcd
Author: huafengw <>
Date:   2017-08-30T06:18:21Z

    [BEAM-2632] Use Junit Paramaterized test suits in TextIOReadTest


> TextIOReadTest create pipelines with non-unique application names
> -----------------------------------------------------------------
>                 Key: BEAM-2632
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Huafeng Wang
>            Priority: Trivial
>              Labels: newbie, starter
> The test {{TextIOReadTest}} uses a loop to create a few tests within a single test method.
This results in a pipeline with non-unique applied transform nodes.
> Perhaps the best way to fix this is to use a JUnit {{Paramaterized}} test suite, or multiple.
It does seem that the test is basically doing the full product of empty/tiny/large with various
compression types.

This message was sent by Atlassian JIRA

View raw message