beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Ribeiro (JIRA)" <>
Subject [jira] [Commented] (BEAM-2577) IO tests should exercise Runtime Values where supported
Date Wed, 23 Aug 2017 20:48:00 GMT


Daniel Ribeiro commented on BEAM-2577:

This seems to be fixed here:

> IO tests should exercise Runtime Values where supported
> -------------------------------------------------------
>                 Key: BEAM-2577
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-extensions, testing
>            Reporter: Ben Chambers
>            Assignee: Davor Bonaci
> The only tests I have found for `ValueProvider<?>` parameterized methods is that
they are not evaluated during pipeline construction time. This is missing out on several important
> 1.
seems to be a problem with an AvroIO write using a RuntimeValueProvider being non-serializable
(current theory is because of an anonymous inner class capturing the enclosing AvroIO.Write
instance which has non-serializable fields).
> 2. Testing that the code paths that actually read the file do so correctly when parameterized.
> We should update the developer documentation to describe what the requirements are for
a parameterized IO and provide guidance on what tests are needed and how to write them.

This message was sent by Atlassian JIRA

View raw message