Mailing-List: contact commits-help@beam.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.apache.org
Date: Tue, 25 Jul 2017 18:48:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.apache.org
Message-ID: <JIRA.13088479.1500486695000.10573.1501008480091@Atlassian.JIRA>
In-Reply-To: <JIRA.13088479.1500486695000@Atlassian.JIRA>
References: <JIRA.13088479.1500486695000@Atlassian.JIRA> <JIRA.13088479.1500486695399@jira-lw-us.apache.org>
Subject: [jira] [Commented] (BEAM-2640) Introduce
 Create.ofProvider(ValueProvider)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Tue, 25 Jul 2017 18:48:04 -0000


    [ https://issues.apache.org/jira/browse/BEAM-2640?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16100=
547#comment-16100547 ]=20

ASF GitHub Bot commented on BEAM-2640:
--------------------------------------

GitHub user jkff opened a pull request:

    https://github.com/apache/beam/pull/3639

    [BEAM-2640, BEAM-2641] Introduces TextIO.read().withHintMatchesManyFile=
s()

    Reincarnation of https://github.com/apache/beam/pull/3598 which got clo=
sed by accident
   =20
    In that case it expands to TextIO.readAll(). Implementing this when the=
 filepattern is a ValueProvider nudged me to also implement BEAM-2640 - Cre=
ate.ofProvider(ValueProvider).
   =20
    Links:
    https://issues.apache.org/jira/browse/BEAM-2640
    https://issues.apache.org/jira/browse/BEAM-2641
   =20
    R:=C2=A0@reuvenlaxCC:=C2=A0@sammcveety


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam textio-readall

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3639.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3639
   =20
----
commit 8f594b2726bd85b60df5d8e93a2055586137cd60
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2017-07-19T18:50:58Z

    [BEAM-2640] Introduces Create.ofProvider(ValueProvider)
   =20
    I also converted DatastoreV1 to use this overload, and, as an
    exercise, added a withQuery(ValueProvider) overload to JdbcIO.

commit a3a4e861db8936bf0ba169b6b089a4a1fcfd6557
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2017-07-19T18:51:33Z

    [BEAM-2641] Introduces TextIO.read().withHintMatchesManyFiles()
   =20
    In that case it expands to TextIO.readAll().

----


> Introduce Create.ofProvider(ValueProvider)
> ------------------------------------------
>
>                 Key: BEAM-2640
>                 URL: https://issues.apache.org/jira/browse/BEAM-2640
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-core
>            Reporter: Eugene Kirpichov
>            Assignee: Eugene Kirpichov
>
> When you have a ValueProvider<T> that may or may not be accessible at con=
struction time, a common task is to wrap it into a single-element PCollecti=
on<T>. This is especially common when migrating an IO connector that used s=
omething like Create.of(query) followed by a ParDo, to having query be a Va=
lueProvider.
> Currently this is done in an icky way (e.g. https://github.com/apache/bea=
m/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/b=
eam/sdk/io/gcp/datastore/DatastoreV1.java#L615)
> We should have a convenience helper for that.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)