Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 06A59200CBD for ; Thu, 6 Jul 2017 14:57:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 050B016647B; Thu, 6 Jul 2017 12:57:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4B54016647A for ; Thu, 6 Jul 2017 14:57:10 +0200 (CEST) Received: (qmail 13625 invoked by uid 500); 6 Jul 2017 12:57:04 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 13616 invoked by uid 99); 6 Jul 2017 12:57:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Jul 2017 12:57:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C6C3BCAA32 for ; Thu, 6 Jul 2017 12:57:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.211 X-Spam-Level: X-Spam-Status: No, score=-99.211 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 0kqbb-ZyBt7Y for ; Thu, 6 Jul 2017 12:57:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1F3B25FCB5 for ; Thu, 6 Jul 2017 12:57:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 53C2DE0069 for ; Thu, 6 Jul 2017 12:57:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0C7752464A for ; Thu, 6 Jul 2017 12:57:00 +0000 (UTC) Date: Thu, 6 Jul 2017 12:57:00 +0000 (UTC) From: "Etienne Chauchot (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-2499) Fail to merge Custom Windows in Spark runner MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 06 Jul 2017 12:57:11 -0000 [ https://issues.apache.org/jira/browse/BEAM-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16076452#comment-16076452 ] Etienne Chauchot commented on BEAM-2499: ---------------------------------------- I have started to remove the IntervalWindow cast and make SparkGlobalCombineFn generic to allow merging custom windows > Fail to merge Custom Windows in Spark runner > -------------------------------------------- > > Key: BEAM-2499 > URL: https://issues.apache.org/jira/browse/BEAM-2499 > Project: Beam > Issue Type: Bug > Components: runner-spark > Reporter: Etienne Chauchot > Assignee: Etienne Chauchot > > If we extend {{IntervalWindow}} and we try to merge these custom windows like in this PR: > https://github.com/apache/beam/pull/3286 > Then spark runner fails with > {{org.apache.beam.sdk.Pipeline$PipelineExecutionException: java.lang.ClassCastException: org.apache.beam.sdk.transforms.windowing.IntervalWindow cannot be cast to org.apache.beam.sdk.transforms.windowing.MergingCustomWindowsTest$CustomWindow}} > It seems to be because of the cast to {{IntervalWindow}} there: https://github.com/apache/beam/blob/master/runners/spark/src/main/java/org/apache/beam/runners/spark/translation/SparkGlobalCombineFn.java#L111 -- This message was sent by Atlassian JIRA (v6.4.14#64029)