Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D8B16200CBF for ; Sat, 8 Jul 2017 18:57:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D733416B18F; Sat, 8 Jul 2017 16:57:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2970216B18E for ; Sat, 8 Jul 2017 18:57:06 +0200 (CEST) Received: (qmail 43307 invoked by uid 500); 8 Jul 2017 16:57:05 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 43298 invoked by uid 99); 8 Jul 2017 16:57:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 08 Jul 2017 16:57:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id F0A671A05A1 for ; Sat, 8 Jul 2017 16:57:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id C-uuOoeKPYt8 for ; Sat, 8 Jul 2017 16:57:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C72B95FBDF for ; Sat, 8 Jul 2017 16:57:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 513E8E0069 for ; Sat, 8 Jul 2017 16:57:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0BCBA24686 for ; Sat, 8 Jul 2017 16:57:00 +0000 (UTC) Date: Sat, 8 Jul 2017 16:57:00 +0000 (UTC) From: "Innocent (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (BEAM-2231) ApiSurface should be lazy MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 08 Jul 2017 16:57:07 -0000 [ https://issues.apache.org/jira/browse/BEAM-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079226#comment-16079226 ] Innocent edited comment on BEAM-2231 at 7/8/17 4:56 PM: -------------------------------------------------------- Please Kenn provide more info on this especially because I think {code:java} getAnyExposurePath(Class exposedClass, Set> excluded) {code} that will ultimately perform tuning via {code:java} addExposedTypes() {code} is this ticket only about performing tuning right from the recursive method {code:java} getAnyExposurePath(){code} the reason I am asking is because it is tagged as a bug and I might be missing the most important part. was (Author: evindj): Please Kenn provide more info on this especially because I think {noformat} *no* further _formatting_ is done here {noformat} {code:java} getAnyExposurePath(Class exposedClass, Set> excluded) {code} that will ultimately perform tuning via {code:java} addExposedTypes() {code} is this ticket only about performing tuning right from the recursive method {code:java} getAnyExposurePath() {code} the reason I am asking is because it is tagged as a bug and I might be missing the most important part. > ApiSurface should be lazy > ------------------------- > > Key: BEAM-2231 > URL: https://issues.apache.org/jira/browse/BEAM-2231 > Project: Beam > Issue Type: Bug > Components: sdk-java-core > Reporter: Kenneth Knowles > Assignee: Innocent > > Currently, the ApiSurface loads classes recursively, when they should be pruned before loading by the pruning pattern. This has caused crashes because some classes that are never referenced in our code. -- This message was sent by Atlassian JIRA (v6.4.14#64029)