beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jkff <>
Subject [GitHub] beam pull request #3639: [BEAM-2640, BEAM-2641] Introduces
Date Tue, 25 Jul 2017 18:47:32 GMT
GitHub user jkff opened a pull request:

    [BEAM-2640, BEAM-2641] Introduces

    Reincarnation of which got closed by accident
    In that case it expands to TextIO.readAll(). Implementing this when the filepattern is
a ValueProvider nudged me to also implement BEAM-2640 - Create.ofProvider(ValueProvider).
    R: @reuvenlaxCC: @sammcveety

You can merge this pull request into a Git repository by running:

    $ git pull textio-readall

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3639
commit 8f594b2726bd85b60df5d8e93a2055586137cd60
Author: Eugene Kirpichov <>
Date:   2017-07-19T18:50:58Z

    [BEAM-2640] Introduces Create.ofProvider(ValueProvider)
    I also converted DatastoreV1 to use this overload, and, as an
    exercise, added a withQuery(ValueProvider) overload to JdbcIO.

commit a3a4e861db8936bf0ba169b6b089a4a1fcfd6557
Author: Eugene Kirpichov <>
Date:   2017-07-19T18:51:33Z

    [BEAM-2641] Introduces
    In that case it expands to TextIO.readAll().


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message