beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] beam pull request #3628: [BEAM-2558] Migrate checkCombineFn in TestUtils to ...
Date Mon, 24 Jul 2017 17:55:32 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/3628

    [BEAM-2558] Migrate checkCombineFn in TestUtils to CombineFnTester

    Follow this checklist to help us incorporate your contribution quickly and easily:
    
     - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/)
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
     - [ ] Each commit in the pull request should have a meaningful subject line and body.
     - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [ ] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
     - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
     - [ ] If this contribution is large, please file an Apache [Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    This makes CombineFnTester significantly more discoverable, and usable
    without having dependencies on the test JAR.
    
    Update existing tests.
    
    This is purely a move of code with minor renaming, visibility limiting, and
    updates to include empty accumulators on both ends of `mergeAccumulators`.
    
    Worth considering is also ensuring that the output (as returned by `extractOutput`)
    is not the same as any of the merged accumulators (as doing so potentially interacts
    poorly with a lifted Combine)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam combine_fn_tester

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3628.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3628
    
----
commit 75a7ef967fe488d24b0c633213dd864875874918
Author: Thomas Groh <tgroh@google.com>
Date:   2017-07-20T20:36:04Z

    Migrate checkCombineFn in TestUtils to CombineFnTester
    
    This makes CombineFnTester significantly more discoverable, and usable
    without having dependencies on the test JAR.
    
    Update existing tests.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message