beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] beam pull request #3601: [BEAM-2333] Use RehydratedComponents for memoized r...
Date Thu, 20 Jul 2017 14:44:01 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/3601

    [BEAM-2333] Use RehydratedComponents for memoized rehydration

    Follow this checklist to help us incorporate your contribution quickly and easily:
    
     - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/)
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
     - [x] Each commit in the pull request should have a meaningful subject line and body.
     - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [x] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
     - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
     - [x] If this contribution is large, please file an Apache [Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    This add a `RehydratedComponents` which memoizes every rehydrated Coder, PCollection,
and WindowingStrategy. For PCollections this is mandatory so they can be wired up correctly,
while for Coder and WindowingStrategy it is nice to have to limit the number of extra objects
we create - though the total count is tiny no matter what, it aids debugging and testing to
have fewer.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam RehydratedComponents

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3601.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3601
    
----
commit 9a9b73543e545b8b7dbe3db417746521252f7855
Author: Kenneth Knowles <klk@google.com>
Date:   2017-07-20T03:58:36Z

    Use RehydratedComponents for memoized rehydration

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message