beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2670) ParDoTest.testPipelineOptionsParameter* validatesRunner tests fail on Spark runner
Date Thu, 27 Jul 2017 20:12:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103830#comment-16103830
] 

ASF GitHub Bot commented on BEAM-2670:
--------------------------------------

GitHub user jkff opened a pull request:

    https://github.com/apache/beam/pull/3654

    [BEAM-2670] Fixes SparkRuntimeContext.getPipelineOptions()

    It used a global variable to store the deserialized options, so even if there were several
instances of SparkRuntimeContext created with different PipelineOptions, they would all return
the same value depending on which one was asked first.
    
    R: @jbonofre or @staslev or @kennknowles or @tgroh or pretty much anyone

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam fix-spark

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3654.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3654
    
----
commit 46bf077a8f7f981839cb0461cd308886de177862
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2017-07-27T20:05:23Z

    [BEAM-2670] Fixes SparkRuntimeContext.getPipelineOptions()
    
    It used a global variable to store the deserialized options,
    so even if there were several instances of SparkRuntimeContext
    created with different PipelineOptions, they would all
    return the same value depending on which one was asked first.

----


> ParDoTest.testPipelineOptionsParameter* validatesRunner tests fail on Spark runner
> ----------------------------------------------------------------------------------
>
>                 Key: BEAM-2670
>                 URL: https://issues.apache.org/jira/browse/BEAM-2670
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-spark
>            Reporter: Etienne Chauchot
>            Assignee: Eugene Kirpichov
>            Priority: Minor
>             Fix For: 2.1.0, 2.2.0
>
>
> Tests succeed when run alone but fail when the whole ParDoTest is run. May be related
to PipelineOptions reusing / not cleaning.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message