beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2658) SerializableCoder has higher precedence over ProtoCoder in CoderRegistry#getCoder
Date Wed, 26 Jul 2017 14:55:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16101760#comment-16101760
] 

ASF GitHub Bot commented on BEAM-2658:
--------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/3617


> SerializableCoder has higher precedence over ProtoCoder in CoderRegistry#getCoder
> ---------------------------------------------------------------------------------
>
>                 Key: BEAM-2658
>                 URL: https://issues.apache.org/jira/browse/BEAM-2658
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>    Affects Versions: 2.0.0
>            Reporter: Neville Li
>            Assignee: Davor Bonaci
>            Priority: Minor
>
> {code}
> import com.google.protobuf.Timestamp;
> import org.apache.beam.sdk.Pipeline;
> import org.apache.beam.sdk.coders.CannotProvideCoderException;
> import org.apache.beam.sdk.coders.Coder;
> import org.apache.beam.sdk.options.PipelineOptions;
> import org.apache.beam.sdk.options.PipelineOptionsFactory;
> public class CoderTest {
>   public static void main(String[] args) throws CannotProvideCoderException {
>     PipelineOptions options = PipelineOptionsFactory.fromArgs(args).create();
>     Pipeline pipeline = Pipeline.create(options);
>     Coder<Timestamp> coder = pipeline.getCoderRegistry().getCoder(Timestamp.class);
>     // class org.apache.beam.sdk.coders.SerializableCoder
>     System.out.println(coder.getClass());
>   }
> }
> {code}
> Right now we're sorting {{CoderProviderRegistrar}}s by canonical name but {{SerializableCoderProvider}}
should be added last as a fallback if there're other {{CoderProvider}}s that support the same
type.
> {code}
> Set<CoderProviderRegistrar> registrars = Sets.newTreeSet(ObjectsClassComparator.INSTANCE);
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message