beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2625) Pull request template could use a little more detail
Date Mon, 17 Jul 2017 20:09:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090466#comment-16090466
] 

ASF GitHub Bot commented on BEAM-2625:
--------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/3575

    [BEAM-2625] Update pull request template

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam pr-template

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3575.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3575
    
----
commit ae422e741d1b2d29ef8fb7955a10960737943bb2
Author: Kenneth Knowles <klk@google.com>
Date:   2017-07-17T20:06:26Z

    Update pull request template

----


> Pull request template could use a little more detail
> ----------------------------------------------------
>
>                 Key: BEAM-2625
>                 URL: https://issues.apache.org/jira/browse/BEAM-2625
>             Project: Beam
>          Issue Type: Bug
>          Components: project-management
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>            Priority: Minor
>
> In the mergebot world where we might have contributors curate good commits more frequently,
adding that to the PR checklist seems nice.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message