beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2608) Unclosed BoundedReader in TextIO#ReadTextFn#process()
Date Sat, 15 Jul 2017 17:47:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088682#comment-16088682
] 

ASF GitHub Bot commented on BEAM-2608:
--------------------------------------

GitHub user jkff opened a pull request:

    https://github.com/apache/beam/pull/3567

    [BEAM-2608] Closes the reader in TextIO.readAll()

    R: @tedyu or @reuvenlax 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam read-close

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3567.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3567
    
----
commit dd8ecbb02a5e79dcc36f13dca4e8574de9b9054b
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2017-07-15T17:43:13Z

    [BEAM-2608] Closes the reader in TextIO.readAll()

----


> Unclosed BoundedReader in TextIO#ReadTextFn#process()
> -----------------------------------------------------
>
>                 Key: BEAM-2608
>                 URL: https://issues.apache.org/jira/browse/BEAM-2608
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Ted Yu
>            Assignee: Eugene Kirpichov
>            Priority: Minor
>
> {code}
>         BoundedSource.BoundedReader<String> reader =
>             source
>                 .createForSubrangeOfFile(metadata, range.getFrom(), range.getTo())
>                 .createReader(c.getPipelineOptions());
> {code}
> The reader should be closed upon return.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message