beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Etienne Chauchot (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (BEAM-2606) WindowFnTestUtils should allow using the value in addition to the timestamp of the elements
Date Wed, 12 Jul 2017 14:57:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084090#comment-16084090
] 

Etienne Chauchot edited comment on BEAM-2606 at 7/12/17 2:56 PM:
-----------------------------------------------------------------

[~davor] and [~kenn] I saw your commits on this file WDYT?


was (Author: echauchot):
[~davor] [~kenn] I saw your commits on this file WDYT?

> WindowFnTestUtils should allow using the value in addition to the timestamp of the elements
> -------------------------------------------------------------------------------------------
>
>                 Key: BEAM-2606
>                 URL: https://issues.apache.org/jira/browse/BEAM-2606
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Etienne Chauchot
>            Assignee: Etienne Chauchot
>
> {{WindowFnTestUtils}} relies only on timeStamps for everything related to windows assignment
in the test helpers. But when creating a custom {{WindowFn}} (and most likely CustomWindow
as well), that {{WindowFn}} might rely on element value in addition to timestamp to decide
the windows that will be assigned to the element. To be able to test this kind of custom WindowFn,
we need versions of the helper methods in WindowFnTestUtils that allow passing {{TimeStampedValues}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message