beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Knowles (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (BEAM-2571) Flink ValidatesRunner failing CombineTest.testSlidingWindowsCombineWithContext
Date Mon, 10 Jul 2017 20:41:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16081106#comment-16081106
] 

Kenneth Knowles edited comment on BEAM-2571 at 7/10/17 8:40 PM:
----------------------------------------------------------------

Since this is longstanding, and other tests of side inputs seem OK, I don't feel the same
urgency to block 2.1.0 on it because of this failure. We might consider blocking any release
based on the danger here...

But I am a little surprised we got this far. Perhaps it is just because that one test is tighter
than others?


was (Author: kenn):
Since this is longstanding, and other tests of side inputs seem OK, I don't feel the same
urgency to block 2.1.0 on it. But I am a little surprised we got this far. Perhaps it is just
because that one test is tighter than others?

> Flink ValidatesRunner failing CombineTest.testSlidingWindowsCombineWithContext
> ------------------------------------------------------------------------------
>
>                 Key: BEAM-2571
>                 URL: https://issues.apache.org/jira/browse/BEAM-2571
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink
>            Reporter: Kenneth Knowles
>            Assignee: Aljoscha Krettek
>             Fix For: 2.1.0
>
>
> This appears to have been caused by https://github.com/apache/beam/pull/3429 which fixes
a couple errors in how trigger timers were processed / final panes labeled.
> I am investigating, considering roll back vs forward fix. Since it is an esoteric use
case where I would advise users to use a stateful DoFn instead, I think the bug fixed probably
outweighs the bug introduced. I would like to fix for 2.1.0 but will report back soon.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message