beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Sisk (JIRA)" <j...@apache.org>
Subject [jira] [Created] (BEAM-2554) failIfNoTests: causes issues when trying to run integration tests
Date Wed, 05 Jul 2017 18:41:00 GMT
Stephen Sisk created BEAM-2554:
----------------------------------

             Summary: failIfNoTests: causes issues when trying to run integration tests
                 Key: BEAM-2554
                 URL: https://issues.apache.org/jira/browse/BEAM-2554
             Project: Beam
          Issue Type: Bug
          Components: testing
            Reporter: Stephen Sisk
            Assignee: Davor Bonaci


Summary: 
We have a couple different maven projects in beam that override the failIfNoTests property
in ways that easily affect folks that are trying to run tests and end up having to build those
projects but don't want to run tests in those projects.
 
I think we should remove these overrides since I think they do more harm than good. The fact
that they don't allow overriding by the user is particularly tricky to get around.

Details: 
projects overriding the failIfNoTests in intrusive ways are: 
runners/direct/java/pom.xml (not profile protected at all)
runners/google-cloud-dataflow-java/pom.xml (when run with dataflow-runner profile)
runners/apex/pom.xml (not profile protected)

This shows up in things like perfkitbenchmarker, where if you try to run the default pkb command
for beam, it is failing: (see below for repro recreating what this does) 
python pkb.py --benchmarks=beam_integration_benchmark --beam_it_args=--tempRoot=gs://[bucket]/staging
--beam_sdk=java


To repro: 
mvn -e verify -Dit.test=org.apache.beam.examples.WordCountIT -DskipITs=false -Pdataflow-runner
-DintegrationTestPipelineOptions=["--tempRoot=gs://sisk-test/staging","--runner=TestDataflowRunner"]

This is very reasonable command line that should work (and pkb expects it to work.)

However, this includes a specific test (-Dit.test=..), which means it will fail when it encounters
the google-cloud-dataflow-java project.

cc [~davor] [~jasonkuster]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message