beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2550) test JOINs with DSL methods
Date Thu, 06 Jul 2017 03:34:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075870#comment-16075870
] 

ASF GitHub Bot commented on BEAM-2550:
--------------------------------------

GitHub user xumingming opened a pull request:

    https://github.com/apache/beam/pull/3506

    [BEAM-2550] add UnitTest for JOIN in DSL

    @XuMingmin @takidau 
    
    I have only tested `bounded vs bounded` join scenario, since we already have enumerated
every cases like `bounded vs bounded`, `unbounded vs unbounded` in tests for `BeamJoinRel`,
test here is mainly to test the integration of JOIN with the DSL methods.
    
    Also I kinda fixed a related bug in `BeamIOSourceRel` -- which have not setCoder for the
rows. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xumingming/beam BEAM-2550-test-join-in-dsl

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3506.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3506
    
----
commit 5885d1cad12d28c453603e12c8a11f369d1d6d65
Author: James Xu <xumingmingv@gmail.com>
Date:   2017-07-06T03:29:41Z

    [BEAM-2550] add UnitTest for JOIN in DSL

----


> test JOINs with DSL methods
> ---------------------------
>
>                 Key: BEAM-2550
>                 URL: https://issues.apache.org/jira/browse/BEAM-2550
>             Project: Beam
>          Issue Type: Task
>          Components: dsl-sql
>            Reporter: Xu Mingmin
>            Assignee: James Xu
>              Labels: dsl_sql_merge
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message